mv: 'mv source hardlink' should fail #4831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
Oh, it is unexpected :) |
sylvestre
requested review from
tertsdiepraam and
cakebaker
and removed request for
tertsdiepraam
cakebaker
reviewed
May 7, 2023
cakebaker
reviewed
May 7, 2023
sylvestre
force-pushed
the
mv-hardlink
branch
2 times, most recently
from
2cdfff5 to
9092bb5
Compare
|
GNU testsuite comparison: |
1 similar comment
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
touch a ln a b ./target/debug/coreutils mv --backup=simple a b GNU: tests/mv/hard-4.sh
|
GNU testsuite comparison: |
|
I don't know if you have seen it, but the new tests in |
cakebaker
reviewed
May 8, 2023
|
|
||
| at.hard_link(file_a, file_b); | ||
|
|
||
| at.touch(file_a); |
There was a problem hiding this comment.
Suggested change
| at.touch(file_a); |
I don't know why this second "touch" is there. The test also passes without it.
cakebaker
reviewed
May 8, 2023
According to: https://stackoverflow.com/questions/44913985/creating-hardlinks-and-symlinks-in-android hardlink aren't expected to work on android + fat
|
GNU testsuite comparison: |
This was referenced May 9, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: tests/mv/force.sh