Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mv: validate --target arg #4802

Merged
merged 1 commit into from
Apr 29, 2023
Merged

mv: validate --target arg #4802

merged 1 commit into from
Apr 29, 2023

Conversation

cakebaker
Copy link
Contributor

This PR fixes the hack I mentioned in #4794 (comment) and reverts the change made to mv.rs in #4794.

Now, the check whether --target is a directory is done when processing the args, thus ensuring the target_dir property in the Behavior struct is a directory.

@uutils uutils deleted a comment from github-actions bot Apr 29, 2023
@sylvestre sylvestre merged commit 400cf11 into uutils:main Apr 29, 2023
@cakebaker cakebaker deleted the mv_validate_target_arg branch April 30, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cakebaker @sylvestre