Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some clippy warnings in tests #4759

Merged
merged 4 commits into from
May 12, 2023
Merged

fix some clippy warnings in tests #4759

merged 4 commits into from
May 12, 2023

Conversation

sylvestre
Copy link
Contributor

No description provided.

@cakebaker
Copy link
Contributor

How do you run clippy? With cargo clippy --all-targets I get a single warning in test_du.rs

@sylvestre
Copy link
Contributor Author

with clippy nightly:
cargo clippy --fix -- -W clippy::pedantic

cakebaker
cakebaker reviewed Apr 21, 2023
View reviewed changes
tests/by-util/test_cp.rs
@@ -1392,15 +1392,14 @@ fn test_cp_target_file_dev_null() {
fn test_cp_one_file_system() {
use crate::common::util::AtPath;
use walkdir::WalkDir;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you remove this line? Seems like a useful separator between imports and variable declarations.

@cakebaker cakebaker mentioned this pull request Apr 21, 2023
Merged
@sylvestre @cakebaker
simplify code
536d12d 
Co-authored-by: Daniel Hofstetter <[email protected]>
@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/tail-2/inotify-dir-recreate. tests/tail-2/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?

@cakebaker cakebaker merged commit 98fa941 into uutils:main May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cakebaker cakebaker cakebaker left review comments

@tertsdiepraam tertsdiepraam Awaiting requested review from tertsdiepraam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sylvestre @cakebaker