-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
date: fix error message when opening file #4544
Conversation
GNU testsuite comparison:
|
tests/by-util/test_date.rs
Outdated
@@ -1,5 +1,7 @@ | |||
extern crate regex; | |||
|
|||
use std::os::unix::prelude::PermissionsExt; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to make that line Unix specific - will fail on Windows
Sadly i cannot really test the behavior on window so maybe i enable the test on unix only ? |
yeah, unix only is fine |
Fails on mac:
|
5f6eaee
to
a6cebed
Compare
It's look like the failing tests aren't related to the pull request itself now |
So i draft this one maybe and when #4572 is ready i add the test to it ? |
Sounds like a good plan :) |
Closes #4540