uudoc, uucore_procs: move markdown parsing to HelpParser

[cakebaker]

This PR is related to #4393 (comment) and removes the check for the about section. It also removes the check for the long_about value because no tool sets this value.

[tertsdiepraam]

I'd rather keep this coming from the markdown directly. That enables us to use markdown syntax.

(Currently only backticks, which are removed before we pass them to clap, but render as inline code blocks in the online docs. Full compile-time markdown support is one of the things I'm working on in supporting for the new argument parser.)

[tertsdiepraam]

See this stub of a function:

coreutils/src/uucore_procs/src/lib.rs

Lines 52 to 54 in bc0273f

	fn render_markdown(s: &str) -> String {
	s.replace('`', "")
	}

Also I see we aren't using that function in about, so that's another thing I'll have to look into.

[tertsdiepraam]

I suppose we could skip it for now if it's half-baked anyway. For context, it's all part of this issue #3181, but I got a bit sidetracked on the argument parsing :)

[cakebaker]

Hm, so the usage info should also come from the markdown instead of render_usage?

[tertsdiepraam]

Yeah that one definitely, especially once your other PR for indentation gets merged: #4393. If it would come from render_usage we'd get additional indentation in the online docs.

[cakebaker]

No, there is already a trim in the current implementation (https://github.com/uutils/coreutils/blob/main/src/bin/uudoc.rs#L179) and so #4393 doesn't affect the online docs.

[tertsdiepraam]

Oh right, that one doesn't matter then

[github-actions]

GNU testsuite comparison:

GNU test failed: tests/tail-2/inotify-dir-recreate. tests/tail-2/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?

[cakebaker]

I moved the markdown parsing from uucore_procs into its own crate, help_parser, and made uudoc use it, too. I'm not sure about the location of the crate, somehow it doesn't feel "right" ;-)

[tertsdiepraam]

I like the idea of putting this in a separate crate. I agree that the location doesn't feel quite right, but I can't think of a better one.

[cakebaker]

Initially I tried to add it to uucore, but adding uucore as a dependency of uucore_procs didn't work.

[cakebaker]

The most recent push resolves the merge conflict with #4569

[github-actions]

GNU testsuite comparison:

GNU test failed: tests/tail-2/inotify-dir-recreate. tests/tail-2/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?

[sylvestre]

sorry, it needs to be rebased :)

[sylvestre]

@cakebaker ping ? :)

[github-actions]

GNU testsuite comparison:

Congrats! The gnu test tests/tail-2/inotify-dir-recreate is no longer failing!