Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mktemp: fix PrefixContainsDirSeparator verification #4379

Merged
merged 17 commits into from
Apr 26, 2023
Merged

mktemp: fix PrefixContainsDirSeparator verification #4379

merged 17 commits into from
Apr 26, 2023

Conversation

ZauJulio
Copy link
Contributor

@sylvestre
Copy link
Contributor

could you please add a test to make sure we don't regress in the future ?

tertsdiepraam
tertsdiepraam reviewed Feb 16, 2023
View reviewed changes
Copy link
Member

@tertsdiepraam tertsdiepraam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Though it's a bit sad we have to convert to a String (and a test would indeed be nice).

src/uu/mktemp/src/mktemp.rs Outdated Show resolved Hide resolved
@ZauJulio
Copy link
Contributor Author

could you please add a test to make sure we don't regress in the future ?

Well remembered, I'll do it as soon as I get back

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/tail-2/inotify-dir-recreate. tests/tail-2/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?

1 similar comment
@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/tail-2/inotify-dir-recreate. tests/tail-2/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?

@sylvestre
Copy link
Contributor

@ZauJulio ping ? :)

@ZauJulio
Copy link
Contributor Author

@ZauJulio ping ? :)

Carnival is finally over here in Brazil, I'll upload the test and send it today : ]

@ZauJulio
Copy link
Contributor Author

@ZauJulio ping ? :)

done, I believe that is enough.
I loved contributing to the project, I'm going to start my studies in Rust and intend to continue here 🧡

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/tail-2/inotify-dir-recreate. tests/tail-2/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?

tertsdiepraam
tertsdiepraam reviewed Feb 26, 2023
View reviewed changes
tests/by-util/test_mktemp.rs Outdated Show resolved Hide resolved
src/uu/mktemp/src/mktemp.rs Outdated Show resolved Hide resolved
@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/misc/tee. tests/misc/tee is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/tail-2/inotify-dir-recreate. tests/tail-2/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?

ZauJulio
ZauJulio commented Feb 27, 2023
View reviewed changes
Copy link
Contributor Author

@ZauJulio ZauJulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently it was so simple, I'll pay more attention 😅

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/misc/timeout. tests/misc/timeout is passing on 'main'. Maybe you have to rebase?

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

GNU testsuite comparison:

Congrats! The gnu test tests/tail-2/inotify-dir-recreate is no longer failing!

tertsdiepraam
tertsdiepraam reviewed Mar 1, 2023
View reviewed changes
Copy link
Member

@tertsdiepraam tertsdiepraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a rustfmt issue, but otherwise it's good

@ZauJulio ZauJulio requested a review from tertsdiepraam March 2, 2023 18:31
@ZauJulio
Copy link
Contributor Author

ZauJulio commented Mar 2, 2023

There's a rustfmt issue, but otherwise it's good

show, I just uploaded the fmt correction

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

GNU testsuite comparison:

GNU test failed: tests/misc/timeout. tests/misc/timeout is passing on 'main'. Maybe you have to rebase?

@ZauJulio
Copy link
Contributor Author

Hi @tertsdiepraam , I was wondering about the current state of PR, do you need anything else? If yes, how can I help you?

@sylvestre sylvestre merged commit 0f26842 into uutils:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tertsdiepraam tertsdiepraam tertsdiepraam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mktemp: wrong prefix verification
3 participants
@ZauJulio @sylvestre @tertsdiepraam