Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated values_of_os() with get_many() #3848

Merged

Conversation

cakebaker
Copy link
Contributor

This PR replaces the usage of clap's deprecated values_of_os() with get_many().

@sylvestre sylvestre merged commit e9eb962 into uutils:main Aug 20, 2022
@cakebaker cakebaker deleted the clap_replace_deprecated_values_of_os branch August 20, 2022 07:36
@niyaznigmatullin
Copy link
Contributor

Seems that tests/misc/chcon-fail.sh fails (https://github.com/uutils/coreutils/runs/7929749317?check_suite_focus=true) because get_many panics

$ ~/repositories/uutils/target/release/coreutils chcon CON
thread 'main' panicked at 'Mismatch between definition and access of `[hash: 9C23C7ACDF5F96F4]`. Could not downcast to TypeId { t: 8720431896296821101 }, need to downcast to TypeId { t: 17148897548463411393 }
', /home/niyaz/repositories/uutils/src/uu/chcon/src/chcon.rs:360:29
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants