Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/dd: fix broken pipe in test_bytes_oseek_bytes_trunc_oflag #3797

Conversation

niyaznigmatullin
Copy link
Contributor

Fixes #3581

I think that happens because count=0 is stated, dd won't read anything from stdin. So the process could finish before we wrote something to stdin pipe, and broken pipe error is raised.

  • Add ignore_stdin_write_error for this test

@sylvestre
Copy link
Contributor

The mac test failures are unrelated:


---- test_uptime::test_uptime stdout ----
current_directory_resolved: 
run: /Users/runner/work/coreutils/coreutils/target/debug/coreutils uptime
---- test_uptime::test_uptime stderr ----
thread 'main' panicked at 'Command was expected to succeed.
stdout = 
 stderr = uptime: could not retrieve system uptime
', tests/common/util.rs:176:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- test_uptime::test_uptime_since stdout ----
current_directory_resolved: 
run: /Users/runner/work/coreutils/coreutils/target/debug/coreutils uptime --since
---- test_uptime::test_uptime_since stderr ----
thread 'main' panicked at 'Command was expected to succeed.
stdout = 
 stderr = uptime: could not retrieve system uptime
', tests/common/util.rs:176:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@sylvestre sylvestre merged commit 2a6371f into uutils:main Aug 8, 2022
@niyaznigmatullin niyaznigmatullin deleted the fix_broken_pipe_test_bytes_oseek_bytes_trunc_oflag branch August 14, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dd test_bytes_oseek_bytes_trunc_oflag flaky test on MacOS
2 participants