Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable numfmt and printf LONG_MIN and INT_MAX+1 gnu-tests #3781

Merged
merged 2 commits into from
Aug 9, 2022

Conversation

niyaznigmatullin
Copy link
Contributor

Discussion #3772

Disables three tests mentioned there

@niyaznigmatullin niyaznigmatullin changed the title disable numfmt and printf MIN_LONG and MAX_INT gnu-tests disable numfmt and printf LONG_MIN and INT_MAX+1 gnu-tests Aug 5, 2022
@tertsdiepraam
Copy link
Member

tertsdiepraam commented Aug 5, 2022

I can indeed confirm that we don't have the numfmt limitation, because we use unsigned_abs to make the padding positive.

https://github.com/uutils/coreutils/blob/main/src/uu/numfmt/src/format.rs#L344

@niyaznigmatullin niyaznigmatullin force-pushed the disable_max_value_tests branch 2 times, most recently from 1ff28aa to ea25c7c Compare August 8, 2022 13:39
@niyaznigmatullin niyaznigmatullin force-pushed the disable_max_value_tests branch from ea25c7c to 5978185 Compare August 9, 2022 05:35
@sylvestre sylvestre merged commit 87415f0 into uutils:main Aug 9, 2022
@niyaznigmatullin niyaznigmatullin deleted the disable_max_value_tests branch August 14, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants