-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
paste: handle list ending with unescaped backslash #3661
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hm, looks like it doesn't work on Windows... |
sylvestre
force-pushed
the
unescaped_backslash
branch
from
July 7, 2022 13:23
d4ccc5e
to
cad9ed5
Compare
sylvestre
force-pushed
the
unescaped_backslash
branch
from
October 5, 2022 11:38
cad9ed5
to
c2283fb
Compare
sylvestre
force-pushed
the
unescaped_backslash
branch
from
February 18, 2023 19:58
c2283fb
to
76c9e22
Compare
GNU testsuite comparison:
|
Fails with:
|
sylvestre
force-pushed
the
unescaped_backslash
branch
from
March 27, 2023 18:57
76c9e22
to
62e3303
Compare
@cakebaker still interested by this PR ? |
GNU testsuite comparison:
|
cakebaker
force-pushed
the
unescaped_backslash
branch
from
April 3, 2023 09:00
62e3303
to
ba9683a
Compare
GNU testsuite comparison:
|
Failed with:
|
cakebaker
force-pushed
the
unescaped_backslash
branch
from
April 28, 2023 13:10
ba9683a
to
736a00a
Compare
GNU testsuite comparison:
|
As I'm unable to fix the Windows-related issue I disabled the failing test for Windows. |
Sounds good, especially with "Congrats! The gnu test tests/misc/paste is no longer failing!" :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show an error if the user provides a delimiter list ending with an unescaped backslash. For example,
paste -d'\'
will now show an error whereaspaste -d'\\'
will work fine.This makes the tests
delim-bs1
anddelim-bs2
in https://github.com/coreutils/coreutils/blob/master/tests/misc/paste.pl pass.