Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mktemp: respect POSIXLY_CORRECT env var when parsing args #3604

Merged
merged 1 commit into from
Jun 9, 2022
Merged

mktemp: respect POSIXLY_CORRECT env var when parsing args #3604

merged 1 commit into from
Jun 9, 2022

Conversation

weijunji
Copy link
Contributor

@weijunji weijunji commented Jun 9, 2022

Fix issue #3587.

Now the GNU test suite suffix9f in tests/misc/mktemp.pl can pass.

@weijunji weijunji force-pushed the mktemp-fix branch 2 times, most recently from 249d0fe to 6cfb0f0 Compare June 9, 2022 09:33
tertsdiepraam
tertsdiepraam requested changes Jun 9, 2022
View reviewed changes
Copy link
Member

@tertsdiepraam tertsdiepraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! We should somehow find a way to implement this for all utils, but we'll figure that out. when we get to it.

src/uu/mktemp/src/mktemp.rs Outdated Show resolved Hide resolved
@weijunji weijunji force-pushed the mktemp-fix branch 5 times, most recently from a7fc41f to 3406fb2 Compare June 9, 2022 12:49
@weijunji weijunji requested a review from tertsdiepraam June 9, 2022 14:41
tertsdiepraam
tertsdiepraam approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@tertsdiepraam tertsdiepraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tertsdiepraam tertsdiepraam merged commit 95de5f6 into uutils:main Jun 9, 2022
@weijunji weijunji deleted the mktemp-fix branch June 10, 2022 02:16
@cakebaker cakebaker mentioned this pull request Jun 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tertsdiepraam tertsdiepraam tertsdiepraam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weijunji @tertsdiepraam