Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include io-blksize parameter #3064

Merged
merged 3 commits into from Feb 14, 2022
Merged

include io-blksize parameter #3064

merged 3 commits into from Feb 14, 2022

Conversation

ghost
Copy link

@ghost ghost commented Feb 4, 2022

Closes #2864

Copy link
Member

@tertsdiepraam tertsdiepraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for adding tests for this too!

@ghost
Copy link
Author

ghost commented Feb 14, 2022

Is there something I need to do to close this pull request?

@tertsdiepraam tertsdiepraam merged commit 6d63717 into uutils:main Feb 14, 2022
@tertsdiepraam
Copy link
Member

No, I should've merged this 8 days ago :)

@alextibbles
Copy link
Contributor

FYI I noticed this test failure today:

failures:

---- test_split::test_split_number_with_io_blksize stdout ----
current_directory_resolved: 
run: /home/alex/code/rust/coreutils/target/debug/coreutils split -n 5 asciilowercase.txt ---io-blksize 1024
open: /tmp/user/1000/.tmpM2oq8D/xaa
open: /tmp/user/1000/.tmpM2oq8D/xab
open: /tmp/user/1000/.tmpM2oq8D/xac
open: /tmp/user/1000/.tmpM2oq8D/xad
open: /tmp/user/1000/.tmpM2oq8D/xae
thread 'test_split::test_split_number_with_io_blksize' panicked at 'assertion failed: `(left == right)`
  left: `"uvwxyz\n"`,
 right: `"uvwxyz"`', /home/alex/code/rust/coreutils/tests/by-util/test_split.rs:466:5

Running my system split manually it looks like the behavior is correct, so the expectation should be updated to include the \n.

@ghost
Copy link
Author

ghost commented Feb 15, 2022

@alextibbles Good catch. I have to update a newly introduced test case to incorporate some changes between the commit and the merge.

@ghost
Copy link
Author

ghost commented Feb 15, 2022

I created a pull request #3140. Please take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

split: implement undocumented option ---io-blksize
3 participants