truncate: change cli error return code #3012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exit with status code 1 for argument parsing errors in `truncate`. When `clap` encounters an error during argument parsing, it exits with status code 2. This causes some GNU tests to fail since they expect status code 1.
shoriminimoe
changed the title
src/uu/truncate/src/truncate.rs
Outdated
| e.print().expect("Error writing clap::Error"); | ||
| match e.kind { | ||
| clap::ErrorKind::DisplayHelp | clap::ErrorKind::DisplayVersion => { | ||
| std::process::exit(0) |
There was a problem hiding this comment.
Nit to make it a bit cleaner using UResult and so that we don't have to call std::process:exit:
.map_err(|e| {
e.print().expect("Error writing clap::Error");
match e.kind {
clap::ErrorKind::DisplayHelp | clap::ErrorKind::DisplayVersion => 0,
_ => 1,
}
})?;There was a problem hiding this comment.
I love it. Working on it now.
tertsdiepraam
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exit with status code 1 for argument parsing errors in
truncate. Whenclapencounters an error during argument parsing, it exits with status code 2. This causes some GNU tests to fail since they expect status code 1.Closes #2951