realpath: add -L and -P command-line arguments #2530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfinkels
force-pushed
the
realpath-logical-physical-args
branch
from
b4793ad to
14977c8
Compare
miDeb
reviewed
Jul 29, 2021
Refactor the `uucore::fs::canonicalize()` function into three helper functions. The first gets the absolute name of the path, the second breaks the path into its components, and the third resolves all symbolic links in the path.
Add the `logical` argument to the `uucore::fs::canonicalize()` function. This argument controls whether symbolic links are resolved before or after ".." components are resolved.
Add the `-L` (logical) and `-P` (physical) command-line arguments to `realpath`. The `-L` option makes the program resolve ".." components before symbolic links. The `-P` option makes the program resolve symbolic links as they are encountered. This also changes the default behavior of `realpath` from the `-L` behavior to the `-P` behavior. This matches the behavior of GNU `realpath`.
jfinkels
force-pushed
the
realpath-logical-physical-args
branch
from
14977c8 to
65037a4
Compare
|
I have made the changes suggested by @miDeb and rebased this branch on |
|
Looks like I've broken the Windows and Mac builds. I only have Linux, so if someone sees an obvious fix that would be very helpful to me. |
|
I think maybe I'll post a new pull request containing just the changes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves issue #2253.
This pull request adds the
-L(logical) and-P(physical) command-line arguments torealpath. The-Loption makes the program resolve ".." components before symbolic links. The-Poption makes the program resolve symbolic links as they are encountered. This also changes the default behavior ofrealpathfrom the-Lbehavior to the-Pbehavior. This matches the behavior of GNUrealpath. I don't fully understand all the things that-Lis supposed to do, but this is a start, and seems to match the basic tests in the GNU coreutils test suite.