fix ~ expr: update onig/onig_sys dependency (fixes windows compilation bug) #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR now includes the workaround within the AppVeyor CI config to fix "gnu" ABI test builds (#1318; |
This was referenced Nov 24, 2018
rivy
changed the title
rivy
force-pushed
the
fix.expr
branch
2 times, most recently
from
c6b9e3b
to
bedd08e
Compare
rivy
force-pushed
the
fix.expr
branch
12 times, most recently
from
18629ed
to
6b38761
Compare
…bugs)
* fixes compile bugs blocking compilation "onig_sys" (required for `expr`) on windows
- MSVC/VS tools are no longer required to be prepped and available on the PATH (via
`vsvarsall` or the "VCX command prompt")
- GNU `gcc` compilation/targets are possible on windows
* restrict onig version to v4.3.2 (or later patches [only]; see discussion)
.# Discussion
onig v4.3.0/v4.3.1 inadvertently introduced a new minimum rust version (requiring
v1.31+; see rust-onig/rust-onig#97). This was repaired with
v4.3.2 (requiring only v1.27.0+), and onig now specifies a rust minimum version that will
stay the same for patches, but may change between minor version increments.
* includes a fix/workaround for ongoing `gcc` library issues - see github:rust-lang/rust#47048 and github:rust-lang/rust#53454 - note: this fix is required for successful gcc/gnu compilation of `expr` on windows * improves clarity and logging of the AppVeyor config * "install" phase is more generic and more easily usable within other rust crates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.