Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mv: -i shouldn't show error message if overwriting is declined #4724

Closed
cakebaker opened this issue Apr 10, 2023 · 4 comments · Fixed by #4773
Closed

mv: -i shouldn't show error message if overwriting is declined #4724

cakebaker opened this issue Apr 10, 2023 · 4 comments · Fixed by #4773
Labels

Comments

@cakebaker
Copy link
Contributor

Setup:

$ mkdir example
$ touch a
$ cp a example/

With GNU mv:

$ mv a example/ -i
mv: overwrite 'example/a'? n
$ echo $?
1

With uutils mv:

$ cargo run mv a example/ -i
mv: overwrite 'example/a'? n
mv: cannot move 'a' to 'example/a': 
$ echo $?
1

It works fine if I specify the filename:

$ cargo run mv a example/a -i
mv: overwrite 'example/a'? n
$ echo $?
1
@sylvestre
Copy link
Contributor

hmm, i am a bit confused @cakebaker
See:
#4630
and
#4627

@cakebaker cakebaker linked a pull request Apr 12, 2023 that will close this issue
@cakebaker
Copy link
Contributor Author

Now I'm confused too ;-) I don't understand what you mean with your comment...

@sylvestre
Copy link
Contributor

@cakebaker see upstream recent change:
coreutils/coreutils@7a69df8

#4731 is reverting my fix

@cakebaker
Copy link
Contributor Author

cakebaker commented Apr 12, 2023

The PR is incorrect, I added a test case in #4731 (comment) to reproduce the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
2 participants