all: return code for invalid options

[ghost]

ref: #3320

Edit: Though the below described issue fails the gnu test tests/misc/usage_vs_getopt.sh, it does not mark it in ERROR state as I originally thought. I have created another issue #3333 which is causing the test to be marked in ERROR state.

This issue will potentially fix the gnu test failure tests/misc/usage_vs_getopts. At least, this is one of the issue why the test is in ERROR state.

The gnu utils exits with error code 1 when there is a argument mismatch. uutils does not in some (may be all) cases.

gnu

> b2sum --thisoptiondoesnotexist
b2sum: unrecognized option '--thisoptiondoesnotexist'
Try 'b2sum --help' for more information.
> echo $?
1

uutils

> ./target/release/b2sum --thisoptiondosenotexist
error: Found argument '--thisoptiondosenotexist' which wasn't expected, or isn't valid in this context

        If you tried to supply `--thisoptiondosenotexist` as a value rather than a flag, use `-- --thisoptiondosenotexist`

USAGE:
    b2sum [OPTIONS] [FILE]...

For more information try --help
> echo $?
2

[sylvestre]

I am working on this

[sylvestre]

I think we have some incorrect parsing/different output :)

many thanks for opening this bug
are you doing it for the other ERROR ?

[ghost]

I am going through them randomly. I'll create issues for the ones I find at least one of the cause for ERROR.

[sylvestre]

Cool, excellent :)

[sylvestre]

Interesting, it is clap's internal number:
https://github.com/clap-rs/clap/blob/7aa45667f5fb364dec4fe0ea9303164ed4d9e171/src/error/mod.rs#L108-L109=
https://github.com/clap-rs/clap/blob/1f17d9e8ba5b64baca9e2d49c1b097b167bf4df6/src/util/mod.rs#L23=

[sylvestre]

Small world:
clap-rs/clap#3426 ;)

[tertsdiepraam]

The discussion here might also be relevant: #3102 (it's the issue that led me to create that issue on clap)

[sylvestre]

I think we are good now