mktemp: respect TMPDIR environment variable

Change `mktemp` so that it respects the value of the `TMPDIR`
environment variable, if no directory is otherwise specified in its
arguments. For example, before this commit

    $ TMPDIR=. mktemp
    /tmp/tmp.WDJ66MaS1T

After this commit,

    $ TMPDIR=. mktemp
    ./tmp.h96VZBhv8P

This matches the behavior of GNU `mktemp`.

src/uu/mktemp/src/mktemp.rs

@@ -17,6 +17,7 @@ use std::env;
 use std::error::Error;
 use std::fmt::Display;
 use std::iter;
+use std::ops::Deref;
 use std::path::{is_separator, Path, PathBuf, MAIN_SEPARATOR};
 
 #[cfg(unix)]
@@ -41,6 +42,11 @@ static OPT_T: &str = "t";
 
 static ARG_TEMPLATE: &str = "template";
 
+#[cfg(not(windows))]
+const TMPDIR: &str = "TMPDIR";
+#[cfg(windows)]
+const TMPDIR: &str = "TMP";
+
 #[derive(Debug)]
 enum MkTempError {
     PersistError(PathBuf),
@@ -89,6 +95,34 @@ impl Display for MkTempError {
     }
 }
 
+/// Decide whether a [`PathBuf`] represents the empty path, analogous to the empty string.
+fn path_buf_is_empty<P>(p: P) -> bool
+where
+    P: Deref<Target = Path>,
+{
+    p.as_os_str().is_empty()
+}
+
+fn tmpdir_from_template<P>(path: &P) -> PathBuf
+where
+    P: Deref<Target = Path>,
+{
+    // It is possible that the prefix of the template includes a path
+    // separator, like `mktemp a/bXXX`. In this case, the `tmpdir`
+    // should be set to `a/` and the template should be set to
+    // `bXXX`. If there is no path separator, then the `tmpdir` should
+    // be the value of the `TMPDIR` environment variable if set,
+    // otherwise the current directory.
+    match path.parent() {
+        None => PathBuf::from("."),
+        Some(d) if path_buf_is_empty(d) => match env::var(TMPDIR) {
+            Ok(dir) => PathBuf::from(dir),
+            Err(_) => PathBuf::from(d),
+        },
+        Some(d) => PathBuf::from(d),
+    }
+}
+
 #[uucore::main]
 pub fn uumain(args: impl uucore::Args) -> UResult<()> {
     let matches = uu_app().get_matches_from(args);
@@ -128,10 +162,16 @@ pub fn uumain(args: impl uucore::Args) -> UResult<()> {
         // to parse out the parent directory and the filename from the
         // argument `XXX`, since it may be include path separators.
         } else {
-            let tmp = match path.parent() {
-                None => PathBuf::from("."),
-                Some(d) => PathBuf::from(d),
-            };
+            // Get the parent directory that will contain the file.
+            //
+            // This could be
+            //
+            // * the prefix of the template, as in `mktemp a/bXXX`,
+            // * the value of the `TMPDIR` environment variable, or
+            // * the current directory.
+            //
+            // See `tmpdir_from_template()` for more information.
+            let tmp = tmpdir_from_template(&path);
             let filename = path.file_name();
             let template = filename.unwrap().to_str().unwrap();
             // If the command line was `mktemp aXXX/b`, then we will

tests/by-util/test_mktemp.rs

@@ -4,7 +4,7 @@ use crate::common::util::*;
 
 use uucore::display::Quotable;
 
-use std::path::PathBuf;
+use std::path::{PathBuf, MAIN_SEPARATOR};
 use tempfile::tempdir;
 
 #[cfg(unix)]
@@ -558,3 +558,24 @@ fn test_too_few_xs_suffix_directory() {
         .fails()
         .stderr_only("mktemp: too few X's in template 'aXXX'\n");
 }
+
+/// Test that files are created relative to `TMPDIR` environment variable.
+#[test]
+fn test_tmpdir_env_var() {
+    let (at, mut ucmd) = at_and_ucmd!();
+
+    // Create a subdirectory within the test fixture directory; we'll
+    // assign `TMPDIR` to be this subdirectory.
+    at.mkdir("d");
+    let dir = at.plus_as_string("d");
+
+    // Create a temporary file under `dir`.
+    let result = ucmd.env(TMPDIR, &dir).succeeds();
+    let filename = result.no_stderr().stdout_str().trim_end();
+
+    // The default template is 10 Xs following "tmp.", and we expect
+    // that to be under the `dir` that we created above.
+    let template = format!("{}{}tmp.XXXXXXXXXX", dir, MAIN_SEPARATOR);
+    assert_matches_template!(&template, filename);
+    assert!(at.file_exists(filename));
+}