Replace bundlesize with bundlewatch #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctavan
force-pushed
the
replace-bundlesize-with-bundlewatch
branch
2 times, most recently
from
a92ccff to
75c6f71
Compare
broofa
approved these changes
Feb 10, 2020
There was a problem hiding this comment.
bundlewatch has smaller dependency graph, which is never a bad thing. http://npm.broofa.com/?q=bundlesize vs http://npm.broofa.com/?q=bundlewatch
|
I'm watching http://npm.broofa.com/?q=@ampproject/filesize as well which has an even smaller dependency graph, however it doesn't support reporting differences w.r.t. master out of the box yet. |
This should be done by every developer in the global gitignore file depending on whether they are on MacOS or use IntelliJ or whatever, it should not be part of this project-specific .gitignore file.
Bundlesize is unmaintained and currently doesn't support reporting differences compared to master, see: siddharthkp/bundlesize#308 As mentioned here, Bundlewatch seems to be a working successor: GoogleChrome/lighthouse#10272 (comment)
ctavan
force-pushed
the
replace-bundlesize-with-bundlewatch
branch
from
75c6f71 to
043a761
Compare
|
BTW apparently during the last few hours there was a problem on GitHubs side with verifying signed commits which has now been resolved, however commits need to be rewritten in order for GitHub to pick up the changes. This is why I had to rebase once more… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately bundlewatch also doesn't seem to be super actively maintained however at least the server-side service seems to be working at the moment so we git diffs w.r.t. master directly in the Github check.
Since I can't find any drawbacks w.r.t. bundlesize I'd give it a try.