uuid versions into separate modules, per #154 #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,6 @@ | |||
| { | |||
There was a problem hiding this comment.
We should just drop this file. I forgot to delete it when I merged the two repos.
| @@ -1,14 +1,13 @@ | |||
| { | |||
| "name": "uuid", | |||
| "version": "3.0.0", | |||
| "version": "3.1.0", | |||
There was a problem hiding this comment.
no version changes in PRs, those happen after once ready to release (with changelog updates accordingly).
| }; | ||
|
|
||
| rng.isCrypto = false; |
There was a problem hiding this comment.
unrelated to separating out into files?
|
👍 overall, just need to remove the version bump (FYI use the defunctzombie/changelog module to manage the changelog and release versions separately from PRs once I know what will go into the version). Also the addition of the new isCrypto api should be a separate PR. |
defunctzombie
approved these changes
Nov 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.