Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rand to 0.7 #423

Closed
wants to merge 1 commit into from
Closed

Upgrade rand to 0.7 #423

wants to merge 1 commit into from

Conversation

mati865
Copy link

@mati865 mati865 commented Aug 17, 2019

I'm submitting a(n) (other)

Description

Motivation

Getting rid of old rand versions.

Tests

Ran cargo test on Linux.

Related Issue(s)

@Dylan-DPC-zz
Copy link
Member

Thanks for the PR. We had to close a similar effort earlier because of #417

@mati865
Copy link
Author

mati865 commented Aug 17, 2019

Getrandom became no_std crate, I'll see if it still fails.

@mati865
Copy link
Author

mati865 commented Aug 17, 2019

I'll open issue in getrandom repo, sorry for the noise.

@mati865 mati865 closed this Aug 17, 2019
@Dylan-DPC-zz
Copy link
Member

No problem and thanks for opening the issue. When you have done so, leave a comment here.

@mati865
Copy link
Author

mati865 commented Aug 17, 2019

The issue is basically rust-random/getrandom#4
It can be worked around by bumping MSRV to 1.32: https://travis-ci.com/mati865/uuid/builds/123603614 but it's not strictly no_std.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants