Silicon progress tracing #949
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's talk about redoing this work in #978: it additionally refactors the progress system to support parallel tasks + multiline progress information. I've made a rudimentary implementation of this that pretty much just does .toString on the most recent MemberRecord, ExecuteRecord, {Produce|Consume}Record |
|
I think it looks quite nice now, please let me know soon if you would like to keep the work in this branch around |
bobismijnnaam
commented
Mar 23, 2023
| @@ -518,6 +518,8 @@ case class SimplifyNestedQuantifiers[Pre <: Generation]() extends Rewriter[Pre] | |||
|
|
|||
| case class Pointer[G](index: Expr[G], subnodes: Seq[Node[G]], array: Expr[G]) extends Subscript[G] | |||
|
|
|||
| case class Sequence[G](index: Expr[G], subnodes: Seq[Node[G]], array: Expr[G]) extends Subscript[G] | |||
|
|
|||
There was a problem hiding this comment.
@niomaster This is the only change of interest, and it's not actually related to the intention of the silicon-progress-tracing branch. I think it's also in #950. So as far as I'm concerned this branch can be deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds rudimentary silicon progress tracing in vercors by pretty printing all origins in the current trace maintained in symbexlogger. It uses the jAnsi library to control the terminal cursor, clear the screen, etc.
This proof of concept works but more work is needed to make it just as friendly as the current progress printer: there should be a flag to turn it off, it shouldn't be on when stdout is not a tty, it should not use placeholder strings like "XXX", etc. Not sure if it is useful enough to warrant the investment, but it certainly looks cool.