Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change vsum axioms to only return null upon an empty range, and not an invalid range #699

Merged
merged 2 commits into from
Oct 4, 2021
Merged

Change vsum axioms to only return null upon an empty range, and not an invalid range #699

merged 2 commits into from
Oct 4, 2021

Conversation

bobismijnnaam
Copy link
Contributor

No description provided.

@bobismijnnaam bobismijnnaam temporarily deployed to Default October 4, 2021 13:50 Inactive
@bobismijnnaam bobismijnnaam temporarily deployed to Default October 4, 2021 14:12 Inactive
@bobismijnnaam bobismijnnaam temporarily deployed to Default October 4, 2021 14:14 Inactive
@bobismijnnaam bobismijnnaam temporarily deployed to Default October 4, 2021 14:28 Inactive
@bobismijnnaam bobismijnnaam temporarily deployed to Default October 4, 2021 14:28 Inactive
pieter-bos
pieter-bos approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@pieter-bos pieter-bos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to reiterate for posterity: this is fine (since the original axiom was unsound, due to j >= vsize(xs) not being a strict bound), but let's take a better look at vectors/matrices at some point.

@bobismijnnaam bobismijnnaam merged commit 678dfff into dev Oct 4, 2021
@bobismijnnaam bobismijnnaam deleted the fix-vectorexpr-r2-axiom branch October 4, 2021 14:31
@bobismijnnaam bobismijnnaam temporarily deployed to Default October 4, 2021 14:48 Inactive
@bobismijnnaam bobismijnnaam temporarily deployed to Default October 4, 2021 14:49 Inactive
@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieter-bos pieter-bos pieter-bos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobismijnnaam @pieter-bos