Partially reinstate problem fail tests #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required some rewriting since the grammar has changed since it was removed from the test suite. Also, changed silicon to carbon, since it seems a bit faster that way.
bobismijnnaam
force-pushed
the
partially-reinstate-problem-fail-tests
branch
from
8261b95 to
ee05bb1
Compare
This required turning off Flatten.java inside ADTs, since there no flattening is necessary given a correct input program. If strict typechecking (e.g. prevention of use of methods in ADTs) is needed inside ADTs in silver, this should be implemented in the future in the typechecker.
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR marks two unstably failing tests (leader elect & OpenMPSectionReducedFail1) with
--stop-before-backend, so they will not be verified with silicon anymore. We track their instability in #514.This pr marks all tests in problem-fail that fail because of the back-end as
--stop-before-backend, and marks all tests that fail because of a pass with--stop-after-typecheck. These tests are removed from problem-fail if they are marked with one of these flags, and added to the suite problem-partial.Finally, some tests are removed from problem-fail, as in the meantime the problems have been fixed.
This PR closes #651.
It needs to be rebased from main, as it builds upon commits in #657.Files left: