Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final fix for coverage #656

Merged
merged 10 commits into from
Jul 13, 2021
Merged

Final fix for coverage #656

merged 10 commits into from
Jul 13, 2021

Conversation

bobismijnnaam
Copy link
Contributor

There was a bug that caused the coverage reports not to be merged correctly in the action, causing sonarcloud to display 0% coverage.

@bobismijnnaam bobismijnnaam temporarily deployed to Default July 12, 2021 21:46 Inactive
@bobismijnnaam bobismijnnaam temporarily deployed to Default July 12, 2021 22:03 Inactive
@bobismijnnaam bobismijnnaam temporarily deployed to Default July 12, 2021 22:04 Inactive
@sonarcloud
Copy link

sonarcloud bot commented Jul 12, 2021

@bobismijnnaam
Copy link
Contributor Author

I think the coverage code smell can be ignored, as it concerns coverage in the test suite code, and it requires changing the CI to get the coverage there, so I don't think it's worth the effort.

@Vescatur
Copy link
Contributor

I think the coverage code smell can be ignored, as it concerns coverage in the test suite code, and it requires changing the CI to get the coverage there, so I don't think it's worth the effort.

I am questioning the usability of the rule for us. Since most of the project is not covered by tests it will give a lot of warnings.

@Vescatur Vescatur merged commit 75a8be7 into dev Jul 13, 2021
@bobismijnnaam bobismijnnaam deleted the debug-coverage branch July 13, 2021 10:47
@bobismijnnaam
Copy link
Contributor Author

Since most of the project is not covered by tests it will give a lot of warnings.

We'll have to see I guess. We can also turn off the coverage for certain classes/packages, I think, that might help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants