-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final fix for coverage #656
Conversation
…urations for intellij included in the git repo.
…the one directory that _is_ included
SonarCloud Quality Gate failed. |
I think the coverage code smell can be ignored, as it concerns coverage in the test suite code, and it requires changing the CI to get the coverage there, so I don't think it's worth the effort. |
I am questioning the usability of the rule for us. Since most of the project is not covered by tests it will give a lot of warnings. |
We'll have to see I guess. We can also turn off the coverage for certain classes/packages, I think, that might help. |
There was a bug that caused the coverage reports not to be merged correctly in the action, causing sonarcloud to display 0% coverage.