Predicate refactor 2 #639

bobismijnnaam · 2021-05-11T15:04:59Z

This is a continuation of #528, to avoid a merge commit that seemed a bit messy.

Improve support for predicates.

Inline predicates can be scaled.
Add tests for inline predicates.
Unfolding and folding of inline predicates is now encoded as asserting the predicate body, and a warning is emitted.
Infinite inline recursive predicates are disallowed
Add inline methods to the feature system

src/main/java/vct/col/rewrite/InlinePredicatesAndFunctions.java

sonarcloud · 2021-05-12T11:14:28Z

Kudos, SonarCloud Quality Gate passed!

bobismijnnaam added 2 commits May 11, 2021 16:46

Get code from branch predicate-refactor to avoid merge commit

01defea

Turn on the new predicate inline pass.

59dd60f

bobismijnnaam temporarily deployed to Default May 11, 2021 15:05 Inactive

bobismijnnaam mentioned this pull request May 11, 2021

Predicate refactor #528

Closed

Disallow recursive inline predicates.

23c9e06

bobismijnnaam temporarily deployed to Default May 11, 2021 15:27 Inactive

Add inline to feature system.

ceab803

bobismijnnaam temporarily deployed to Default May 12, 2021 07:44 Inactive

Replace (un)fold of inline predicate with assert.

5055304

bobismijnnaam temporarily deployed to Default May 12, 2021 08:19 Inactive

pieter-bos approved these changes May 12, 2021

View reviewed changes

src/main/java/vct/col/rewrite/InlinePredicatesAndFunctions.java Outdated Show resolved Hide resolved

Update dead link.

cb83d31

bobismijnnaam temporarily deployed to Default May 12, 2021 11:08 Inactive

bobismijnnaam merged commit 377e497 into dev May 12, 2021

bobismijnnaam deleted the predicate-refactor-2 branch May 12, 2021 11:13

Provide feedback