Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on JDK 21+, resolves #1146 #1212

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Fix build on JDK 21+, resolves #1146 #1212

merged 1 commit into from
Jun 5, 2024

Conversation

superaxander
Copy link
Member

Files were not being generated leading to the missing packages in #1146

It seems on newer JDKs there is no $ after Lambda so that caused our name matching to fail.

Example of what a class name looks like now:

scala.meta.internal.prettyprinters.TreeSyntax$SyntaxInstances$$Lambda/0x00007f00eac376f8

@superaxander superaxander linked an issue Jun 5, 2024 that may be closed by this pull request
@superaxander
Copy link
Member Author

I was wondering why the ??? didn't cause an exception which would've failed the generation phase of the build, but it happens inside a Using where the resulting Try is ignored

@pieter-bos
Copy link
Member

Yeah I've just misunderstood how Using works, likely all uses of Using should be replaced with Using.resource. Like I mentioned recently these would have been catched by -Wvalue-discard, but it has a good number of false positives for our code.

@pieter-bos pieter-bos merged commit 8627a3f into dev Jun 5, 2024
16 of 19 checks passed
@pieter-bos pieter-bos deleted the fix-1146 branch June 5, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building VerCors on Java 21 results in package ops not found error
2 participants