-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for SYCL's accessors and declarators. #1100
Conversation
I've not merged this yet because you are failing this test: https://github.com/utwente-fmt/vercors/actions/runs/6768903759/job/18394515499?pr=1100 |
You mean this?
These two tests are commented out in SYCLTest, because they need a flag to pass, see my comment here I see two options to solve this:
These tests are quite important, as they test some core functionality of SYCL's data accessors. I also expect to add more example files for the next research questions which will probably have the same issue. So I think I would prefer the first option, what do you think? |
Right, sorry. Let's go for the first solution right now, I'll think about adding flags to test fixtures. |
I added the tests. I did have to add the line |
Added support for SYCL's accessors and declarators, so now data on the host can be copied to kernels and written back to the host when the kernels are done. An example of the supported usage of accessors and declarators can be seen below (taken from
examples/concepts/sycl/accessors/GetKernelResult.cpp
):