-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DeserializeOrigin to LLVMOrigin rewriter #1007
Conversation
I corrected the style and naming issues. Regarding the aforementioned type check issue: Perhaps it would be possible to make |
…quired (was optional before)
I first need to make some changes in VCLLVM before i can test whether the changes work as intended (which will take time), but at least it compiles. Seeing how this PR has been open for a while, it might be best to merge it now before the merge conflicts get complicated to solve. But that call is for @niomaster to make. |
Sure, but please address the review comments:
|
This pull request adds a rewriter that transforms
DeserializeOrigin
toLLVMOrigin
.An issue right now is that i think the type checker is ran before any rewriter is. This means by the time type check errors are reported, the
DeserializeOrigin
is used which is not very descriptive.I'm not sure if and how this could be fixed.