Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default constructor misses idle token #646

Closed
raulmonti opened this issue Jul 6, 2021 · 3 comments
Closed

Default constructor misses idle token #646

raulmonti opened this issue Jul 6, 2021 · 3 comments
Assignees
Labels
A-Bug R Rewriting problem

Comments

@raulmonti
Copy link
Contributor

raulmonti commented Jul 6, 2021

The default constructor for PVL classes misses to inhale and ensure the idle token in its contract, which is required to be able to fork instances of this class.

@raulmonti raulmonti self-assigned this Jul 6, 2021
raulmonti added a commit that referenced this issue Jul 7, 2021
raulmonti added a commit that referenced this issue Jul 7, 2021
@bobismijnnaam
Copy link
Contributor

This problem appears in examples/manual/fork.pvl, but because of the way the test is written, the error is hidden. Would you mind if I add this test to the branch where you are doing this? As it is also a nice test for your fix. (The test must be split up into three files, one for each testX method. test1 must succeed, but test2 and test3 must fail. This is because the "verdict" syntax is very loose and broken in the test suite...)

@raulmonti
Copy link
Contributor Author

This problem appears in examples/manual/fork.pvl, but because of the way the test is written, the error is hidden. Would you mind if I add this test to the branch where you are doing this? As it is also a nice test for your fix. (The test must be split up into three files, one for each testX method. test1 must succeed, but test2 and test3 must fail. This is because the "verdict" syntax is very loose and broken in the test suite...)

Yes! go ahead :) I will push a new commit after that, where I moved the is_runnable testing to the ASTClass instead of inlining it when building the default constructor.

@bobismijnnaam
Copy link
Contributor

bobismijnnaam commented Jul 8, 2021

The change is applied on Petra's PR (#652), so you can pull that in once that is merged. (Sorry for the confusion)

@raulmonti raulmonti added the A-Bug label Jul 8, 2021
@pieter-bos pieter-bos added the R Rewriting problem label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Bug R Rewriting problem
Projects
None yet
Development

No branches or pull requests

3 participants