-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default constructor misses idle token #646
Comments
This problem appears in examples/manual/fork.pvl, but because of the way the test is written, the error is hidden. Would you mind if I add this test to the branch where you are doing this? As it is also a nice test for your fix. (The test must be split up into three files, one for each testX method. test1 must succeed, but test2 and test3 must fail. This is because the "verdict" syntax is very loose and broken in the test suite...) |
Yes! go ahead :) I will push a new commit after that, where I moved the is_runnable testing to the ASTClass instead of inlining it when building the default constructor. |
The change is applied on Petra's PR (#652), so you can pull that in once that is merged. (Sorry for the confusion) |
The default constructor for PVL classes misses to inhale and ensure the idle token in its contract, which is required to be able to fork instances of this class.
The text was updated successfully, but these errors were encountered: