Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The git commit for VerCors is not set, but it is soundness-critical #1050

Closed
pieter-bos opened this issue Jul 3, 2023 · 0 comments
Closed

The git commit for VerCors is not set, but it is soundness-critical #1050

pieter-bos opened this issue Jul 3, 2023 · 0 comments
Labels
A-Bug B-Viper Backend: Silicon and Carbon

Comments

@pieter-bos
Copy link
Member

Since the caching component keys on the commits of silicon, carbon, silver and vercors itself, we have to set the git commit to a correct value, lest we load cached results from a prior VerCors version. The odds of this actually causing soundness problems is pretty low.
@pieter-bos pieter-bos added A-Bug B-Viper Backend: Silicon and Carbon labels Jul 3, 2023
pieter-bos added a commit that referenced this issue Oct 12, 2023
@pieter-bos
Merge pull request #1072 from utwente-fmt/issue-1050
0650c8f 
fix #1050: set git buildinfos for caching properly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Bug B-Viper Backend: Silicon and Carbon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pieter-bos