Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactions on main post #340

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

arunvelsriram
Copy link
Contributor

@arunvelsriram arunvelsriram commented Jun 14, 2020

Related issue: #188

This is a work in progress PR. Lot of things to implemented/handled.

Done:

  1. Show/submit reactions for existing issue
  2. Show/submit reaction on new issue created by first comment
  3. Show total reaction count

Pending things on top of my head:

  1. Fix error when reacting on new issue created through a reactions button
  2. Fix issue with updating the reaction count
  3. Disable when user is not logged in
  4. UI for showing "signin to react"
  5. Style for various themes

Currently it looks like this:

Screenshot 2020-06-15 at 12 03 43 AM

@arunvelsriram
Copy link
Contributor Author

I have pushed changes for:

  1. Fix error when reacting on new issue created through a reactions button
  2. Fix issue with updating the reaction count
  3. Disable when user is not logged in

For, 4. UI for showing "signin to react":
Just a thought - there is a "Sign in to comment" already, we could rename it to "Sign in" and avoid creating another Sign in button. If you think a separate Sign in button is required for reactions, I would need your input on where to place the the Sign in button.

For, 5. Style for various themes:
I tested this. It appears to be working fine.

New screenshot:

Screenshot 2020-06-16 at 12 36 51 AM

@arunvelsriram
Copy link
Contributor Author

arunvelsriram commented Jun 15, 2020

The reaction buttons are getting wrapped to a new line unevenly and there is some issue with border as well in small screens. Let me know you thoughts on handling this.

Screenshot 2020-06-16 at 12 43 00 AM

@arunvelsriram arunvelsriram changed the title WIP: Reactions on main post Reactions on main post Jun 16, 2020
@techboyg5
Copy link
Contributor

I think that the reactions button should be in a popup menu on the far right side of the line that says "X Comments - powered by utteranc.es".

@brennerm
Copy link

brennerm commented Dec 4, 2020

@arunvelsriram Will you continue working on this topic? I'd really like to see this feature coming.

@arunvelsriram
Copy link
Contributor Author

Functionality wise everything is covered as far as I remember. There are UI improvements and we need to decide about the Sign In button.

I don't have much experience in UI development. Please fee l free to add improvements on top of this.

@willianantunes
Copy link

@arunvelsriram, you did fantastic work with this feature! It works like DISQUS. Pretty cool!

Is the Sign In button issue a must-have requirement? Can this PR be merged without this, and then another PR be created to solve the button UX, if required? Emoji Reactions can be enabled as a "beta" feature, let's say through the JS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants