Fix default value retrieval for resources and node paths #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piiertho
previously approved these changes
Aug 31, 2024
CedNaru
force-pushed
the
bugfix/fix-default-value-retrieval-for-resources-and-node-paths
branch
from
212a657 to
92e5f51
Compare
piiertho
approved these changes
Sep 1, 2024
|
@CedNaru as i opened this PR i cannot approve it. But i approve :-) |
CedNaru
approved these changes
Sep 1, 2024
CedNaru
deleted the
bugfix/fix-default-value-retrieval-for-resources-and-node-paths
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resources should still gather default values.
For node types (which are treated as node paths in the inspector) we return an empty variant so we can set them.
@CedNaru please look at this carefully. I'm very unsure if this is the proper way of dealing with this, but it works