enh: Simplify cpp core type buffer protocol read and write #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piiertho
force-pushed
the
enhancement/simplify-kotlin-to-cpp-core-type-read
branch
from
14fabdd to
c178302
Compare
CedNaru
previously approved these changes
May 11, 2024
CedNaru
previously approved these changes
May 11, 2024
chippmann
previously approved these changes
May 12, 2024
piiertho
force-pushed
the
enhancement/simplify-kotlin-to-cpp-core-type-read
branch
from
6dadf0c to
2f9e5d2
Compare
piiertho
changed the title
piiertho
force-pushed
the
enhancement/simplify-kotlin-to-cpp-core-type-read
branch
from
2f9e5d2 to
3853053
Compare
piiertho
changed the title
|
Test on Android |
CedNaru
approved these changes
May 13, 2024
|
Tested on iOS |
chippmann
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplify cpp read and write buffer protocol for core types.
This reinterprets byte buffer to core type to avoid multiple calls to get each primitives.
This needs test on all platforms to be sure we don't have memory layout troubles, even if we shouldn't as all core types are perfectly aligned.