Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Java source files #592

Merged
merged 11 commits into from
Apr 1, 2024
Merged

Conversation

CedNaru
Copy link
Member

@CedNaru CedNaru commented Mar 30, 2024

Like for Kotlin files, the module can now handle Java files. They can be attached to Nodes and open in the editor with minimal support.
I did a heavy lifting of the Script and Language classes so they can handle each language individually.
The documentation and logs have been updated to mention Java files and use more generic words like "Jvm" or "Source file" when it applies to both languages.

@CedNaru CedNaru requested review from piiertho and chippmann March 30, 2024 18:45
@CedNaru CedNaru marked this pull request as ready for review March 30, 2024 18:46
Copy link
Contributor

@chippmann chippmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm. Nice work!

Still unhappy about the JavaScript naming situation but if we don't find a better name, it should not block merging...

src/gd_kotlin.cpp Show resolved Hide resolved
src/script/jvm_instance.cpp Outdated Show resolved Hide resolved
@CedNaru CedNaru merged commit 9fdef01 into master Apr 1, 2024
29 of 30 checks passed
@CedNaru CedNaru deleted the feature/javascript_yes_this_name branch April 1, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants