Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reflection usage in exported projects #572

Merged
merged 3 commits into from
Mar 26, 2024

Conversation

chippmann
Copy link
Contributor

@chippmann chippmann commented Feb 7, 2024

Fixes #571

Note: this is intended as a quick fix for #571 so we can publish a hotfix.
We still need to further investigate if a separate bootstrap jar for exported projects is still a good idea and still needed or if we should just export the bootstrap jar we ship with the editor.

@piiertho the graalvm config for the newly added tests are missing here. As i cannot remember how to check which configs are missing, could you give me a quick heads up again on discord?

This was tested on linux x64 on editor builds, debug and release exports.

Marked as draft until missing graalvm configs are added.

@chippmann chippmann requested review from CedNaru and piiertho February 7, 2024 06:17
@chippmann
Copy link
Contributor Author

@MartinHaeusler I'd appreciate if you could test this with your project as well if possible and you have the time.

@chippmann chippmann force-pushed the bugfix/GH-571_fix-reflection-usage branch from d748bec to 6979803 Compare February 7, 2024 07:08
@chippmann chippmann marked this pull request as ready for review February 7, 2024 07:34
@MartinHaeusler
Copy link
Contributor

@chippmann I've just tested it locally; I checked out this PR from github, built the godot plugin, published to maven local, loaded it from there in my project, and did a clean build of my project. The godot-bootstrap.jar which was created this way now contains the full kotlin/reflect/jvm and kotlin/reflect/full packages. I then used the godot editor to export the project and started the standalone executable; everything worked like a charm!

Thank you very much for your efforts :)

@chippmann chippmann force-pushed the bugfix/GH-571_fix-reflection-usage branch from ec693be to 00c4800 Compare March 11, 2024 17:07
@chippmann chippmann merged commit 99c6f8b into master Mar 26, 2024
35 checks passed
@chippmann chippmann deleted the bugfix/GH-571_fix-reflection-usage branch March 26, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kotlin reflection not always applied to bootstrap jar in exported projects
4 participants