Rewind() called early in TransferContext #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CedNaru
force-pushed
the
feature/early-rewind
branch
from
4a8d4f2 to
784010e
Compare
CedNaru
requested review from
piiertho and
chippmann
and removed request for
piiertho
chippmann
requested changes
Oct 14, 2023
chippmann
approved these changes
Oct 14, 2023
piiertho
reviewed
Oct 14, 2023
kt/godot-library/src/main/kotlin/godot/core/memory/TransferContext.kt
Outdated
Show resolved
Hide resolved
CedNaru
force-pushed
the
feature/early-rewind
branch
from
93549f5 to
474a8a6
Compare
piiertho
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement #509
C++:
The idea is simple. Instead of having to call
rewind()after any operation on the buffer, we simply rewind it as part of theget_buffer()method. (The buffer is stored directly inside that method, so it's the only way to get it).The only manual
rewind()left is the one inicall()as I need to reset it to write the return value.Kotlin:
I decided to made
TransferContext.bufferprivate (doesn't change its visibility from C++ through JNI). I don't think it should be used directly outside TransferContext, so I did a small rework of its methods.The goal was to remove any manual call to
rewind()in the rest of the code. Rewinding should be the responsibility of TransferContext alone.