Added support for Alibaba Cloud storage adapter #95
Conversation
Signed-off-by: nidhi-singh02 <[email protected]>
nidhi-singh02
force-pushed
the
feat-6408-alibabacloud-storage-adapter
branch
from
f93fb2c to
a3a956c
Compare
|
Hey @nidhi-singh02, thank you for your contribution! ✨ |
|
|
||
| protected function setUp(): void | ||
| { | ||
| $this->alibaba = new Alibaba('accessKey', 'secretKey', 'bucket', 'endpoint'); |
There was a problem hiding this comment.
You need to pass actual values of accessKey, secretKey etc. Those values can either be added to environment variables and read from there or you can take a reference from the S3 adapter.
|
|
||
| public function testRead() | ||
| { | ||
| $this->expectException(OssException::class); |
There was a problem hiding this comment.
The tests need to ensure that the method works as expected. You can use a test Alibaba Cloud account, read values from there and assert that the value is being read properly. Similarly for other tests.
|
|
||
| public function testExists() | ||
| { | ||
| $this->expectException(OssException::class); |
There was a problem hiding this comment.
Add tests for all cases like when the value exists and when it doesn't exist.
|
@nidhi-singh02 have you made any progress? If yes, please update the same. |
|
Hey, Due to time constraints, I'm going to mark this PR When it is merged, we'll contact you for Appwrite-specific Hacktoberfest swag. Thanks for helping us improve Appwrite! |
|
Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship. Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag. |
That's great to hear. My discord user name is "nidzi." |
|
Will reach out ASAP, adding everyone's names to a spread sheet to reach out together. Thank you for your patience :) |
Added support for Alibaba Cloud storage adapter