Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add xz compression #59

Merged
merged 8 commits into from
Apr 6, 2023
Merged

feat: add xz compression #59

merged 8 commits into from
Apr 6, 2023

Conversation

unickorn
Copy link
Contributor

@unickorn unickorn commented Oct 10, 2022 •
edited
Loading

@stnguyen90 stnguyen90 linked an issue Oct 18, 2022 that may be closed by this pull request
🗜️ Refine Appwrite Storage with xz Compression appwrite/appwrite#4003
Closed
6 tasks
@stnguyen90 stnguyen90 self-requested a review October 18, 2022 00:45
stnguyen90
stnguyen90 requested changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local tests look good:

image

Dockerfile Outdated Show resolved Hide resolved
tests/Storage/Compression/Algorithms/XZTest.php Outdated Show resolved Hide resolved
@stnguyen90
Copy link
Contributor

@unickorn Great PR! 🤯 We left some comments during the review, please check them out.

@unickorn unickorn requested a review from stnguyen90 October 18, 2022 04:11
stnguyen90
stnguyen90 approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are still passing!

image

@unickorn Hey 👋 awesome work on your PR! We've approved your work and it'll be merged soon!

@christyjacob4
Copy link
Contributor

Please sync your branch with main . It has fixes for the failing CI tests

@christyjacob4
Copy link
Contributor

@unickorn please resolve the merge conflicts

@christyjacob4 christyjacob4 merged commit adf1690 into utopia-php:main Apr 6, 2023
@christyjacob4
Copy link
Contributor

THANK YOU! All changes merged 🥳

Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord.  

You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub.

You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile.

Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stnguyen90 stnguyen90 stnguyen90 approved these changes

@christyjacob4 christyjacob4 Awaiting requested review from christyjacob4

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🗜️ Refine Appwrite Storage with xz Compression
3 participants
@unickorn @stnguyen90 @christyjacob4