Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Snappy compression #56

Merged

Conversation

precious-void
Copy link
Contributor

Resolves #4002

@Meldiron
Copy link
Contributor

@shtelzerartem , thanks for the PR! 🤯 Please give us some time to review it.

@Meldiron
Copy link
Contributor

I took a look at the failing test and it seems to say:

Exception: <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<Error>
    <Code>InvalidAccessKeyId</Code>
    <Message>Malformed Access Key Id</Message>
</Error>

Do you think this might be related to your changes? If not, it is probably S3 secrets we have on the repo. Please let me know, and if it's on our side, Ill investigate further.

@precious-void
Copy link
Contributor Author

precious-void commented Oct 10, 2022

I took a look at the failing test and it seems to say:

Exception: <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<Error>
    <Code>InvalidAccessKeyId</Code>
    <Message>Malformed Access Key Id</Message>
</Error>

Do you think this might be related to your changes? If not, it is probably S3 secrets we have on the repo. Please let me know, and if it's on our side, Ill investigate further.

Hey, @Meldiron!

This error is not related to my PR. Try filtering only to Algorithms folder and local tests.

I see @stnguyen90 was running tests like this in #55:

docker-compose exec tests vendor/bin/phpunit --configuration phpunit.xml --debug --filter "(Algorithms)|(Validator)|(StorageTest)|(LocalTest)"

@precious-void
Copy link
Contributor Author

Hey @Meldiron!
Did I answer your question? Can I help you resolving any problems connected to it?

@stnguyen90 stnguyen90 self-requested a review October 17, 2022 23:47
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running local tests:

$ docker-compose exec tests vendor/bin/phpunit --configuration phpunit.xml --debug --filter "(Algorithms)|(Validator)|(StorageTest)|(LocalTest)"

image

Dockerfile Outdated Show resolved Hide resolved
tests/Storage/Compression/Algorithms/SnappyTest.php Outdated Show resolved Hide resolved
tests/Storage/Compression/Algorithms/SnappyTest.php Outdated Show resolved Hide resolved
@stnguyen90
Copy link
Contributor

@shtelzerartem Great PR! 🤯 We left some comments during the review, please check them out.

Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are still successful!

image

@shtelzerartem Hey 👋 awesome work on your PR! We've approved your work and it'll be merged soon!

@christyjacob4
Copy link
Contributor

Please sync your branch with main . It has fixes for the failing CI tests

@precious-void
Copy link
Contributor Author

Please sync your branch with main . It has fixes for the failing CI tests

@christyjacob4 done

@christyjacob4 christyjacob4 merged commit f1da955 into utopia-php:main Dec 20, 2022
@christyjacob4
Copy link
Contributor

THANK YOU! All changes merged 🥳

Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord.  

You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub.

You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile.

Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🗜️ Refine Appwrite Storage with Snappy Compression
4 participants