-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Snappy compression #56
Add Snappy compression #56
Conversation
@shtelzerartem , thanks for the PR! 🤯 Please give us some time to review it. |
I took a look at the failing test and it seems to say:
Do you think this might be related to your changes? If not, it is probably S3 secrets we have on the repo. Please let me know, and if it's on our side, Ill investigate further. |
Hey, @Meldiron! This error is not related to my PR. Try filtering only to I see @stnguyen90 was running tests like this in #55:
|
Hey @Meldiron! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shtelzerartem Great PR! 🤯 We left some comments during the review, please check them out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please sync your branch with |
@christyjacob4 done |
THANK YOU! All changes merged 🥳 Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord. You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub. You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile. Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :) |
Resolves #4002