Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework V2 #102

Merged
merged 90 commits into from
Jan 4, 2024
Merged

Framework V2 #102

merged 90 commits into from
Jan 4, 2024

Conversation

lohanidamodar
Copy link
Contributor

  • Support server adapters

@lohanidamodar lohanidamodar changed the base branch from master to feat-routing-v2 July 11, 2023 05:33
src/Adapter/FPM/Server.php Outdated Show resolved Hide resolved
src/Adapter/Swoole/Files.php Outdated Show resolved Hide resolved
Copy link
Member

@eldadfux eldadfux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress. We need to test both Swoole and FPM. We should also update the readme file.

What are we doing about server initiali`ation callbacks? Can we make the server init look closer to other newer utopia libs? Take Appwrite for example, we have a lot of usage of Swoole callbacks for server start and other events. Can we abstract that nicely?

src/Adapter/Swoole/Files.php Outdated Show resolved Hide resolved
src/Adapter/Swoole/Server.php Outdated Show resolved Hide resolved
src/App.php Outdated Show resolved Hide resolved
@lohanidamodar lohanidamodar requested a review from eldadfux July 12, 2023 02:21
Dockerfile.swoole Show resolved Hide resolved
README.md Show resolved Hide resolved
src/Adapter.php Outdated Show resolved Hide resolved
src/Adapter.php Outdated Show resolved Hide resolved
src/Http/Adapter/Swoole/Server.php Outdated Show resolved Hide resolved
src/Http/Adapter/FPM/Server.php Outdated Show resolved Hide resolved
src/View.php Outdated Show resolved Hide resolved
tests/e2e/server_fpm.php Outdated Show resolved Hide resolved
tests/e2e/server_swoole.php Outdated Show resolved Hide resolved
@eldadfux eldadfux merged commit dc539ee into master Jan 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants