Check database exist before create #329
Conversation
| @@ -49,11 +49,6 @@ public static function getDatabase(): Database | |||
| $database = new Database(new MariaDB($pdo), $cache); | |||
| $database->setDefaultDatabase('utopiaTests'); | |||
| $database->setNamespace('myapp_'.uniqid()); | |||
|
|
|||
| if ($database->exists('utopiaTests')) { | |||
There was a problem hiding this comment.
I remove this, since it is Done in Base.php Tests
There was a problem hiding this comment.
Can you link it? I don't see a call to delete in Base.php
There was a problem hiding this comment.
database/tests/Database/Base.php
Line 72 in 107a633
I guess I can revert this to be more consistent for a fresh start, not to depend on this exist method 👍
|
Do we need this change? Shouldn't it be okay as is with |
|
We had some lock incidents with the create schema, it is triggering a DDL operation, |
@fogelito I don't think this query was the one that held the lock, but the one that was blocked when trying to acquire it |
…abase-check � Conflicts: � src/Database/Adapter/MariaDB.php � src/Database/Adapter/SQL.php
src/Database/Adapter/MariaDB.php
Outdated
| if ($this->exists($name)) { | ||
| return true; | ||
| } | ||
|
|
||
| $sql = "CREATE DATABASE IF NOT EXISTS `{$name}` /*!40100 DEFAULT CHARACTER SET utf8mb4 */;"; |
There was a problem hiding this comment.
| $sql = "CREATE DATABASE IF NOT EXISTS `{$name}` /*!40100 DEFAULT CHARACTER SET utf8mb4 */;"; | |
| $sql = "CREATE DATABASE `{$name}` /*!40100 DEFAULT CHARACTER SET utf8mb4 */;"; |
With the new check we don't really need this.
There was a problem hiding this comment.
Also, do we have the same in other adapters?
No description provided.