-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various Fixes and Improvements for Analytics #51
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PineappleIOnic
changed the title
Remove Error Handling
Various Fixes and Improvements for Analytics
Feb 16, 2024
Meldiron
reviewed
Feb 20, 2024
Meldiron
reviewed
Feb 20, 2024
Meldiron
reviewed
Feb 20, 2024
Meldiron
reviewed
Feb 20, 2024
Meldiron
reviewed
Feb 20, 2024
Co-authored-by: Matej Bačo <[email protected]>
eldadfux
reviewed
Feb 20, 2024
eldadfux
approved these changes
Feb 20, 2024
Meldiron
approved these changes
Feb 20, 2024
This was referenced Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we use a
logError
function to handle exceptions, this removes my ability to better handle it on where we use the library so this PR removes that and just throws directly to give us better visibility when things go wrong.This PR also addresses:
contactExists
function to useget contact
with email propertyId instead ofsearch
this should cover edge cases where users have multiple emails assigned to one contact