Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Fixes and Improvements for Analytics #51

Merged
merged 14 commits into from
Feb 20, 2024

Conversation

PineappleIOnic
Copy link
Member

@PineappleIOnic PineappleIOnic commented Feb 16, 2024

Currently we use a logError function to handle exceptions, this removes my ability to better handle it on where we use the library so this PR removes that and just throws directly to give us better visibility when things go wrong.

This PR also addresses:

  • Made the plausble validate() method use type instead of name
  • Moved tests over to GitHub actions and parallelised them
  • Changes the hubspot contactExists function to use get contact with email propertyId instead of search this should cover edge cases where users have multiple emails assigned to one contact

@PineappleIOnic PineappleIOnic changed the title Remove Error Handling Various Fixes and Improvements for Analytics Feb 16, 2024
@eldadfux eldadfux merged commit 981349b into main Feb 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants