Import testing #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous regex returns two locations. Signed-off-by: Dimitrios Karagiannis <[email protected]>
Cloud VXCs ignore b_end.0.product_uid values. See commit 4899cb1 for an explanation. Signed-off-by: Dimitrios Karagiannis <[email protected]>
Even though MCRv2 does not have a "term" attribute, the API will always return the value `1` for the respective field, which is also the default value. We should not skip updating this field in the state for MCR v2, when reading from the Megaport API. If an MCRv2 is imported, the value will be `null` in state since there is no configuration being parsed. Therefore, this generates a perpetual diff. Updating based on the API will set the default value and prevent this situation. Signed-off-by: Dimitrios Karagiannis <[email protected]>
ribbybibby
approved these changes
Oct 14, 2020
Signed-off-by: Dimitrios Karagiannis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable import testing and resolve an issue with imported MCR v2 resources where
a perpetual diff occurs due to the way the "term" attribute is handled.