-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update color usage with typography components #62
Conversation
UWDS-538 Typography changes
to support the removal of the background colour context and the transition from cwui to Check we still support the |
🦋 Changeset detectedLatest commit: 5192f32 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
f356c0d
to
5192f32
Compare
This changes the way color is handled by the
Text
andHeading
components. As a result of the newly introducedcolour-system
library, these components, andTypography
, will accept astring
value, ideally from thecolour-system
library. Until we get more solid semantic understanding of how colours are used, we will support this more open approach to typography colours.This change also preempts the deprecation, and future removal, of the background colour context that enables typography components to change their colour based on the parent background colour. Because of this, the
Text
andHeading
components will not support this functionality. If they need to be used on a darker brand background, the appropriate text color should be passed in to thecolor
prop.