Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update color usage with typography components #62

Merged
merged 13 commits into from
May 9, 2023
Merged

Conversation

robphoenix
Copy link
Member

@robphoenix robphoenix commented May 5, 2023

This changes the way color is handled by the Text and Heading components. As a result of the newly introduced colour-system library, these components, and Typography, will accept a string value, ideally from the colour-system library. Until we get more solid semantic understanding of how colours are used, we will support this more open approach to typography colours.
This change also preempts the deprecation, and future removal, of the background colour context that enables typography components to change their colour based on the parent background colour. Because of this, the Text and Heading components will not support this functionality. If they need to be used on a darker brand background, the appropriate text color should be passed in to the color prop.

@linear
Copy link

linear bot commented May 5, 2023

UWDS-538 Typography changes

to support the removal of the background colour context and the transition from cwui to web-ui, we should initially support the colour context in the Typography component, but not in the Text & Heading components. Therefore we only have to make the breaking change on the Typography component, and consumers can transition to Text & Heading.

Check we still support the Typography component as it is in CWUI, and only make the breaking change in the next major release.

@changeset-bot
Copy link

changeset-bot bot commented May 5, 2023

🦋 Changeset detected

Latest commit: 5192f32

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@utilitywarehouse/web-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2023 1:11pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant