feat: List component
#446
feat: List component
#446
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
🦋 Changeset detectedLatest commit: f62a716 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🖥️ Native UI - Storybook PreviewVisit the Storybook preview URL to see the changes in action. 📱 Appetize PreviewsYou can view the apps using the link above and choosing the device from the top action bar. Alternatively you can use the direct links below. Last updated from commit bd7ed69 |
| } | ||
| trailingContent={ | ||
| <Radio value="option1" aria-label="Label 1"> | ||
| <RadioIndicator /> |
There was a problem hiding this comment.
Not sure if this is a mistake 🤔 but the RadioIndicator seems to have a colour override when is checked=true
Initially I thought it was only in the context of List Item but it seems that the RadioIndicator has this colour override as well
Figma 👇
There was a problem hiding this comment.
It's a weird issue with storybook, sometimes it builds like that for the web version. Not sure why. It will be resolved when we move away from Gluestack style and it doesn't affect the actual native output se
e the Apptetize output:
There was a problem hiding this comment.
Thanks for the feedback, I will use this view as well to QA
| }, | ||
| }, | ||
| variants: { | ||
| divider: { |
There was a problem hiding this comment.
@jordmccord need for aligment here 👇
In Figma the divider is theDivider component which has it's built in custom props and customisations.
instead of using a border for the List Item, we should flag all dependencies and create tasks for them 🙏 before we create the "bigger"component. In this case we knew about Card and Switch dependency missing, but not Divider. Using a Divider component preserves flexibility and maintains a connection to the actual component. If a designer modifies the Divider props in a List, the engineer can directly change those props instead of overriding these "divider" styles.
Let's ensure this isn't a blocker for release in our app ui alignments. However, we'll need to update the dependency when the Divider becomes a code library component in code and create follow-up tasks accordingly to replace this.
There was a problem hiding this comment.
Agreed, I will replace it when we have the divider component 👍
Adds the
List,ListHeading,ListItemincluding parts andSkeletoncomponents.https://www.figma.com/design/c16vqWI6QZNOPYKeLm2ysz/UWDS-2581---Button-color-alignments-with-web?node-id=2692-3920&m=dev