-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: List
component
#446
feat: List
component
#446
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
🦋 Changeset detectedLatest commit: f62a716 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🖥️ Native UI - Storybook PreviewVisit the Storybook preview URL to see the changes in action. 📱 Appetize PreviewsYou can view the apps using the link above and choosing the device from the top action bar. Alternatively you can use the direct links below. Last updated from commit bd7ed69 |
} | ||
trailingContent={ | ||
<Radio value="option1" aria-label="Label 1"> | ||
<RadioIndicator /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback, I will use this view as well to QA
}, | ||
}, | ||
variants: { | ||
divider: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jordmccord need for aligment here 👇
In Figma the divider is theDivider
component which has it's built in custom props and customisations.
instead of using a border for the List Item
, we should flag all dependencies and create tasks for them 🙏 before we create the "bigger"component. In this case we knew about Card and Switch dependency missing, but not Divider. Using a Divider
component preserves flexibility and maintains a connection to the actual component. If a designer modifies the Divider
props in a List
, the engineer can directly change those props instead of overriding these "divider" styles.
Let's ensure this isn't a blocker for release in our app ui alignments. However, we'll need to update the dependency when the Divider
becomes a code library component in code and create follow-up tasks accordingly to replace this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, I will replace it when we have the divider component 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, we can align on the follow up task regarding Divider, Card and more dependencies 🙏
Adds the
List
,ListHeading
,ListItem
including parts andSkeleton
components.https://www.figma.com/design/c16vqWI6QZNOPYKeLm2ysz/UWDS-2581---Button-color-alignments-with-web?node-id=2692-3920&m=dev