Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move gmail object from children to parent GmailBaseTool #6

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

uthmanmoh
Copy link
Owner

Before we were repeating the following code in each subclass:

const auth = await this.getAuth();
const gmail = google.gmail({ version: "v1", auth });

This was pointless because we had all the params already in the superclass, so this PR moves the gmail object to the parent class so children can just access it through this.gmail

@HamoonZamiri HamoonZamiri merged commit 23dc04d into gmail_feature Nov 20, 2023
12 checks passed
@uthmanmoh uthmanmoh deleted the refactor branch November 20, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants