fixed #33018: Pre8: Export of Survey Question Pool fails ilObjSurveyQ…

…uestionPool::toXML(): Argument #1 () must be of type array…
utesche · Jun 23, 2022 · 6cb0247 · 6cb0247
1 parent 8a95af8
commit 6cb0247
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/Modules/SurveyQuestionPool/Export/class.ilSurveyQuestionPoolExportTableGUI.php b/Modules/SurveyQuestionPool/Export/class.ilSurveyQuestionPoolExportTableGUI.php
@@ -89,7 +89,7 @@ protected function fillRow(array $a_set) : void
         }
         $this->tpl->parseCurrentBlock();
         $this->tpl->setVariable('CB_ID', $this->counter);
-        $this->tpl->setVariable("PHRASE", $a_set["phrase"]);
+        $this->tpl->setVariable("PHRASE", $a_set["phrase"] ?? "");
         $this->tpl->setVariable("FILENAME", ilLegacyFormElementsUtil::prepareFormOutput($a_set['file']));
         $this->tpl->setVariable("SIZE", $a_set["size"]);
         $this->tpl->setVariable("DATE", $a_set["date"]);

diff --git a/Modules/SurveyQuestionPool/classes/class.ilObjSurveyQuestionPool.php b/Modules/SurveyQuestionPool/classes/class.ilObjSurveyQuestionPool.php
@@ -502,9 +502,9 @@ public function getImportDirectory() : string
      * export questions to xml
      * @todo move to export sub-component
      */
-    public function toXML(array $questions) : string
+    public function toXML(?array $questions) : string
     {
-        if (count($questions) === 0) {
+        if (is_null($questions) || count($questions) === 0) {
             $questions = $this->getQuestions();
         }
         $a_xml_writer = new ilXmlWriter();