Skip to content

Commit

Permalink
fix: docker images should tag only in lower-case (#54)
Browse files Browse the repository at this point in the history
Docker images are required to have lower case image names.
See the `PATH` docs here: https://docs.docker.com/reference/cli/docker/image/tag/
  • Loading branch information
tewaro authored Jan 13, 2025
1 parent feebdac commit cee6867
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ KERNEL_VERSION ?= $(shell uname -r)
KERNEL_DEV_HEADERS_DIR ?= /usr/src/kernels/${KERNEL_VERSION}
KERNEL_DEV_SPECIFIC_HEADERS_MOUNT ?=
KERNEL_DEV_MODULES_DIR ?= /lib/modules/${KERNEL_VERSION}
LOWER_UNAME = $(shell echo ${UNAME} | tr A-Z a-z)

# Kernel dev header locations are different on red hat and ubuntu
# First ensure the user has not overridden this field
Expand Down Expand Up @@ -41,7 +42,7 @@ endif

BASE_IMAGE_NAME ?= kernmlops
BCC_IMAGE_NAME ?= ${BASE_IMAGE_NAME}-deps
IMAGE_NAME ?= ${UNAME}-${BASE_IMAGE_NAME}
IMAGE_NAME ?= ${LOWER_UNAME}-${BASE_IMAGE_NAME}
SRC_DIR ?= $(shell pwd)
VERSION ?= $(shell git log --pretty="%h" -1 Dockerfile.dev requirements.txt)

Expand Down

0 comments on commit cee6867

Please sign in to comment.