Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form cleanup fixes #154

Merged
merged 5 commits into from
Oct 7, 2015
Merged

Form cleanup fixes #154

merged 5 commits into from
Oct 7, 2015

Conversation

annez
Copy link
Contributor

@annez annez commented Oct 5, 2015

This is a bit of a re-write from the new forms, as I found we had a lot of styles that were now aligned, it made sense to move everything to extends to make life a bit easier. Here's an overview of what has been changed:

  • @mixin placeholder didn't need to have a @content block as we were only setting the colour to it
  • %base-form-element now has hover/focus/active styles and the default colours across inputs, selects and textareas
  • %base-form-element--error and %base-form-element--success have the default validation styles
  • .us-form-select now doesn't require a wrapper. The background is an SVG on the input, which is supported in Firefox, Opera, Safari, IE10+ and Chrome. No need for pseudo elements
  • _form.scss variables file has been documented and updated to contain the shared border/active styles across all our form elements

All existing us-form-select-wrap classes have been left in but commented as deprecated - so your app, even if using them should work just fine.

This should reduce the overhead of the new forms significantly and ensure that IE10 users don't suffer from the clicking on the arrow and not getting anything.

annez added a commit that referenced this pull request Oct 7, 2015
@annez annez merged commit a4ab62d into master Oct 7, 2015
@annez annez deleted the form-cleanup-fixes branch October 7, 2015 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selects should have same error styling as inputs
1 participant