Form cleanup fixes #154
Merged
Form cleanup fixes #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 2, 2015 15:44
…pper, abstracted most form element vars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a re-write from the new forms, as I found we had a lot of styles that were now aligned, it made sense to move everything to extends to make life a bit easier. Here's an overview of what has been changed:
@mixin placeholderdidn't need to have a@contentblock as we were only setting the colour to it%base-form-elementnow has hover/focus/active styles and the default colours across inputs, selects and textareas%base-form-element--errorand%base-form-element--successhave the default validation styles.us-form-selectnow doesn't require a wrapper. The background is an SVG on the input, which is supported in Firefox, Opera, Safari, IE10+ and Chrome. No need for pseudo elements_form.scssvariables file has been documented and updated to contain the shared border/active styles across all our form elementsAll existing
us-form-select-wrapclasses have been left in but commented asdeprecated- so your app, even if using them should work just fine.This should reduce the overhead of the new forms significantly and ensure that IE10 users don't suffer from the clicking on the arrow and not getting anything.